feat(extra-native-rdr3): `GET_MINIMAP_TYPE` #3150

KadDarem · 2025-02-12T23:52:03Z

Goal of this PR

Get the minimap type in RDR3

...

How is this PR achieving the goal

Return the value 0,1,2 or 3 depending on whether the map is off, standard, expended, or simple.
...

This PR applies to the following area(s)

RedM natives

...

Successfully tested on

Get the minimap type after edit it with SetMinimapType(): ✅
Get the minimap type after edit it in the pause menu: ✅

Game builds: 1491

Platforms: Windows

Checklist

Code compiles and has been tested successfully.
Code explains itself well and/or is documented.
My commit message explains what the changes do and what they are for.
No extra compilation warnings are added by these changes.

Fixes issues

Fixed the missing native to get the minimap type set by SetMinimapType()

outsider31000 · 2025-02-18T05:25:55Z

just a note for the Cfx team if it helps, I was able to test this and works as intended
although I'm not sure if scanning patterns inside native handlers is a good idea...

@KadDarem can you please resolve the comments I made? it's now outdated so it doesnt confuse the team, just to make it easier for them to merge this.

KadDarem · 2025-02-18T23:13:35Z

Hi @outsider31000

I tried to find another pattern to get this value to avoid the launcher crash when I use it outside the native handlers.

I found the pointer valueon CE but his pattern doesn't work. So help is welcoming.

It's the first time I work with pattern scanning, not easy

outsider31000 · 2025-02-18T23:23:48Z

The crash might be occurring because the pattern you're using to locate the address is probably dynamic
and that is also why it works inside the native handler, but this is just my guess...

KadDarem · 2025-02-19T10:47:36Z

Do you have tips to find a better pattern ?
I have the static pointer inside my Cheat engine. I think my method to convert it into a pattern is wrong.

outsider31000 · 2025-02-19T23:14:23Z

I have tried to find it for a couple hours and @Ktos93 also helped , but we weren't able to find one

KadDarem · 2025-02-20T06:55:59Z

I can give you the CE pointer I found if it can help you.
This pointer is valid for the game built from the source code AND for the game from the launcher AND for another guy. Now, we have to found how to read it and it's done.

DaniGP17 · 2025-02-20T07:19:03Z

I can give you the CE pointer I found if it can help you.

Can you share here so other people can try to help?

KadDarem · 2025-02-20T08:20:35Z

<?xml version="1.0" encoding="utf-8"?>
<CheatTable CheatEngineTableVersion="46">
  <CheatEntries>
    <CheatEntry>
      <ID>2</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03EF1058</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>0</Offset>
        <Offset>88</Offset>
        <Offset>0</Offset>
        <Offset>18</Offset>
        <Offset>18</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>3</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03EF1058</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>0</Offset>
        <Offset>88</Offset>
        <Offset>0</Offset>
        <Offset>18</Offset>
        <Offset>90</Offset>
        <Offset>0</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>4</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03ED0EC0</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>68</Offset>
        <Offset>10</Offset>
        <Offset>28</Offset>
        <Offset>18</Offset>
        <Offset>8</Offset>
        <Offset>1E8</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>5</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03ED0EC0</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>68</Offset>
        <Offset>10</Offset>
        <Offset>28</Offset>
        <Offset>18</Offset>
        <Offset>28</Offset>
        <Offset>158</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>6</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03ED0EC0</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>68</Offset>
        <Offset>10</Offset>
        <Offset>28</Offset>
        <Offset>18</Offset>
        <Offset>48</Offset>
        <Offset>150</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>7</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03ED0EC0</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>68</Offset>
        <Offset>10</Offset>
        <Offset>28</Offset>
        <Offset>98</Offset>
        <Offset>8</Offset>
        <Offset>158</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>8</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03ED0EC0</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>68</Offset>
        <Offset>10</Offset>
        <Offset>28</Offset>
        <Offset>98</Offset>
        <Offset>28</Offset>
        <Offset>150</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>9</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03ED0EC0</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>68</Offset>
        <Offset>10</Offset>
        <Offset>28</Offset>
        <Offset>98</Offset>
        <Offset>48</Offset>
        <Offset>128</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>20</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03EF1058</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>0</Offset>
        <Offset>10</Offset>
        <Offset>10</Offset>
        <Offset>18</Offset>
        <Offset>18</Offset>
        <Offset>18</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>21</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03EB98F8</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>0</Offset>
        <Offset>10</Offset>
        <Offset>10</Offset>
        <Offset>10</Offset>
        <Offset>10</Offset>
        <Offset>10</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>22</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03EB98F8</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>0</Offset>
        <Offset>10</Offset>
        <Offset>10</Offset>
        <Offset>10</Offset>
        <Offset>78</Offset>
        <Offset>168</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>23</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03EB98F8</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>0</Offset>
        <Offset>10</Offset>
        <Offset>10</Offset>
        <Offset>78</Offset>
        <Offset>168</Offset>
        <Offset>10</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>25</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03EB98F8</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>0</Offset>
        <Offset>10</Offset>
        <Offset>78</Offset>
        <Offset>168</Offset>
        <Offset>10</Offset>
        <Offset>10</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>26</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03EB98F8</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>0</Offset>
        <Offset>10</Offset>
        <Offset>78</Offset>
        <Offset>168</Offset>
        <Offset>78</Offset>
        <Offset>168</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>27</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03EF1058</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>0</Offset>
        <Offset>90</Offset>
        <Offset>0</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>28</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03EF1058</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>0</Offset>
        <Offset>10</Offset>
        <Offset>18</Offset>
        <Offset>18</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>29</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03EF1058</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>0</Offset>
        <Offset>10</Offset>
        <Offset>18</Offset>
        <Offset>80</Offset>
        <Offset>0</Offset>
        <Offset>0</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>30</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03EF1058</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>0</Offset>
        <Offset>10</Offset>
        <Offset>18</Offset>
        <Offset>90</Offset>
        <Offset>0</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>31</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03EF1058</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>0</Offset>
        <Offset>78</Offset>
        <Offset>0</Offset>
        <Offset>0</Offset>
        <Offset>18</Offset>
        <Offset>18</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>32</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03EF1058</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>0</Offset>
        <Offset>18</Offset>
      </Offsets>
    </CheatEntry>
    <CheatEntry>
      <ID>33</ID>
      <Description>"minimap scan"</Description>
      <LastState Value="3" RealAddress="C350EF90"/>
      <VariableType>Byte</VariableType>
      <Address>"CitiLaunch.exe"+03EF1058</Address>
      <Offsets>
        <Offset>A0</Offset>
        <Offset>0</Offset>
        <Offset>80</Offset>
        <Offset>0</Offset>
        <Offset>0</Offset>
      </Offsets>
    </CheatEntry>
  </CheatEntries>
  <CheatCodes>
    <CodeEntry>
      <Description>minimap :mov eax,[rcx+net-tcp-server.$S1]</Description>
      <AddressString>CitiLaunch.exe+13AE9FC</AddressString>
      <Before>
        <Byte>48</Byte>
        <Byte>8B</Byte>
        <Byte>C1</Byte>
        <Byte>C3</Byte>
        <Byte>CC</Byte>
      </Before>
      <Actual>
        <Byte>8B</Byte>
        <Byte>81</Byte>
        <Byte>A0</Byte>
        <Byte>00</Byte>
        <Byte>00</Byte>
        <Byte>00</Byte>
      </Actual>
      <After>
        <Byte>C3</Byte>
        <Byte>90</Byte>
        <Byte>48</Byte>
        <Byte>83</Byte>
        <Byte>EC</Byte>
      </After>
    </CodeEntry>
  </CheatCodes>
  <UserdefinedSymbols/>
  <Comments>Info about this table:
</Comments>
</CheatTable>

KadDarem · 2025-02-20T08:21:14Z

All of these pointers trigger the correct value of the minimap type.

DaniGP17 · 2025-02-20T08:21:57Z

All of these pointers trigger the correct value of the minimap type.

Nice, I'll try to help with that.

ekaliclua · 2025-02-20T08:24:47Z

I found a pattern like that, now we have to find the correct way to use it

48 8B C1 C3 CC 8B 81 A0 ?? ?? ?? C3 90 48 83 EC 28

this instruction is called every frame.

KadDarem · 2025-02-20T17:49:42Z

I found a lot of interesting patterns from my CE pointers, but all crash my launcher if I put them outside the function with the error
"m_matches.size() == expected"

DaniGP17 · 2025-02-23T11:09:14Z

Hi, I find a function that return the minimap type, the function only receives the instance of the class that we already have declared above in a variable called g_uiMinimap.

static hook::cdecl_stub<uint32_t(void*)> g_uiMinimap_GetType([]()
{
	return hook::get_call(hook::get_pattern("E8 ? ? ? ? 83 F8 ? 74 ? 48 8D 15"));
});

fx::ScriptEngine::RegisterNativeHandler("GET_MINIMAP_TYPE", [](fx::ScriptContext& context)
{
        uint32_t minimapType = g_uiMinimap_GetType(g_uiMinimap);
        
        context.SetResult<int>(minimapType);
});

KadDarem · 2025-02-23T11:15:09Z

Nice ! I will test that to check if it works in my side too.

KadDarem · 2025-02-23T15:28:39Z

It works perfectly, thanks @DaniGP17 .

Can you confirm this refactor resolves your request @outsider31000 ?

DaniGP17 · 2025-02-23T15:29:05Z

It works perfectly, thanks @DaniGP17 .

Glad to hear that 😄

outsider31000 · 2025-02-23T17:27:35Z

it's a static one

I will make spome tests
about the implementation thats up to Cfx wait for their review.

you should squash the commits though @KadDarem

outsider31000 · 2025-02-23T18:19:38Z

I have made some tests and i have to clarify, that this native will only detect the type it has been set either by using the native SetMinimapType or through settings, it will not detect the current type of the minimap, just so people are aware.

for example:
1- if you press ESC the minimap hides as in OFF type 0 but still returns last type set (which you could use IS_RADAR_HIDDEN)
2- if you press and hold TAB it expands as in type 2 expanded but still returns last type set (no way to detect this for now)

which makes sense. thats how it should work.

for a detection of current type we would need another native perhaps like GET_CURRENT_MINIMAP_TYPE so it detects the current state.

KadDarem · 2025-02-23T18:48:22Z

I agree with you; this native is perfect for detecting which setting is used for the minimap. I'm looking for this native because IsRadarHidden() returns true if the minimap type is set to 0. It was impossible to detect if the minimap was hidden by the DISPLAY_RADAR native or by the SET_MINIMAP_TYPE native.

It's now perfectly possible with this new native.

The native name seems to be right for me. The result matches perfectly with SetMinimapType native or with the settings or with the "Radar" prompts. It's not affected by the game context (tab pressing or pause menu). It's perfect to save the minimap type and be able to apply it again later.
If someone want try to find the GET_CURRENT_MINIMAP_TYPE native, feel free to do it in a new PR since this research for GET_MINIMAP_TYPE is done.

PS : I also tested with the "Radar" prompts and the GET_MINIMAP_TYPE returns the correct result too.

outsider31000 · 2025-02-23T18:51:31Z

yeah this works as intended, just dont forget to squash the commits @KadDarem so it doesn't delay any revivews

Update HudNatives.cpp

KadDarem · 2025-02-24T09:01:55Z

Commits squashed.

Thanks for your help everyone ;)

github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Feb 13, 2025

KadDarem mentioned this pull request Feb 15, 2025

Update (menu): Change radar display method to SetMinimapType Jump-On-Studios/RedM-jo_libs#51

Closed

KadDarem force-pushed the extra-native-rdr3/get_minimap_type branch from 58a7a2a to d8dacab Compare February 16, 2025 22:29

KadDarem changed the title ~~feat(extra-native-rdr3): GET_MINIMAP_TYPE~~ feat(extra-native-rdr3): GET_MINIMAP_TYPE Feb 19, 2025

KadDarem force-pushed the extra-native-rdr3/get_minimap_type branch from 5b656b5 to d8dacab Compare February 24, 2025 08:48

KadDarem force-pushed the extra-native-rdr3/get_minimap_type branch from cb42f1c to 333208a Compare February 24, 2025 08:56

feat(extra-native-rdr3): GET_MINIMAP_TYPE

9f06f31

Update HudNatives.cpp

KadDarem force-pushed the extra-native-rdr3/get_minimap_type branch from 333208a to 9f06f31 Compare February 24, 2025 09:00

github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Feb 24, 2025

github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Feb 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(extra-native-rdr3): `GET_MINIMAP_TYPE` #3150

feat(extra-native-rdr3): `GET_MINIMAP_TYPE` #3150

KadDarem commented Feb 12, 2025

outsider31000 commented Feb 18, 2025

KadDarem commented Feb 18, 2025

outsider31000 commented Feb 18, 2025

KadDarem commented Feb 19, 2025

outsider31000 commented Feb 19, 2025

KadDarem commented Feb 20, 2025

DaniGP17 commented Feb 20, 2025

KadDarem commented Feb 20, 2025

KadDarem commented Feb 20, 2025

DaniGP17 commented Feb 20, 2025

ekaliclua commented Feb 20, 2025 •

edited

Loading

KadDarem commented Feb 20, 2025 •

edited

Loading

DaniGP17 commented Feb 23, 2025

KadDarem commented Feb 23, 2025

KadDarem commented Feb 23, 2025

DaniGP17 commented Feb 23, 2025

outsider31000 commented Feb 23, 2025 •

edited

Loading

outsider31000 commented Feb 23, 2025 •

edited

Loading

KadDarem commented Feb 23, 2025

outsider31000 commented Feb 23, 2025

KadDarem commented Feb 24, 2025

feat(extra-native-rdr3): GET_MINIMAP_TYPE #3150

Are you sure you want to change the base?

feat(extra-native-rdr3): GET_MINIMAP_TYPE #3150

Conversation

KadDarem commented Feb 12, 2025

Goal of this PR

How is this PR achieving the goal

This PR applies to the following area(s)

Successfully tested on

Checklist

Fixes issues

outsider31000 commented Feb 18, 2025

KadDarem commented Feb 18, 2025

outsider31000 commented Feb 18, 2025

KadDarem commented Feb 19, 2025

outsider31000 commented Feb 19, 2025

KadDarem commented Feb 20, 2025

DaniGP17 commented Feb 20, 2025

KadDarem commented Feb 20, 2025

KadDarem commented Feb 20, 2025

DaniGP17 commented Feb 20, 2025

ekaliclua commented Feb 20, 2025 • edited Loading

KadDarem commented Feb 20, 2025 • edited Loading

DaniGP17 commented Feb 23, 2025

KadDarem commented Feb 23, 2025

KadDarem commented Feb 23, 2025

DaniGP17 commented Feb 23, 2025

outsider31000 commented Feb 23, 2025 • edited Loading

outsider31000 commented Feb 23, 2025 • edited Loading

KadDarem commented Feb 23, 2025

outsider31000 commented Feb 23, 2025

KadDarem commented Feb 24, 2025

feat(extra-native-rdr3): `GET_MINIMAP_TYPE` #3150

feat(extra-native-rdr3): `GET_MINIMAP_TYPE` #3150

ekaliclua commented Feb 20, 2025 •

edited

Loading

KadDarem commented Feb 20, 2025 •

edited

Loading

outsider31000 commented Feb 23, 2025 •

edited

Loading

outsider31000 commented Feb 23, 2025 •

edited

Loading